Review
CR-318
ADVMACROS-83: Collapse label/labels and label-criteria parameters
Get rid of label-criteria, since we can make the new code work with match-labels.
Under Review
4 files
0 comments
CR-318
ADVMACROS-83: Collapse label/labels and label-criteria parameters
»
Get rid of label-criteria, since we can make the new code work with match-labels.
Ben Speakmon, Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal.
Review
CR-317
Changing doc to match harmonized params. Un-document the...
25903: Changing doc to match harmonized params. Un-document the oldstyle params that we don't want people to use any more.
Under Review
2 files
0 comments
CR-317
Changing doc to match harmonized params. Un-document the...
»
25903: Changing doc to match harmonized params. Un-document the oldstyle params that we don't want people to use any more.
Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal, Ben Speakmon.
Review
CR-316
- ADVMACROS-82: default space search to @self
25907: - ADVMACROS-82: default space search to @self
Under Review
1 file
1 comment
CR-316
- ADVMACROS-82: default space search to @self
»
25907: - ADVMACROS-82: default space search to @self
Jonathan Nolen, Ben Speakmon, Nathan Dwyer, Cheryl Jerozal.
Review
CR-315
[ADVMACROS-74] Used velocity context param to hide the buttons...
25847: [ADVMACROS-74] Used velocity context param to hide the buttons instead. Removed JavaScript and added tests for the non-profile-pic template.
Under Review
6 files
0 comments
CR-315
[ADVMACROS-74] Used velocity context param to hide the buttons...
»
25847: [ADVMACROS-74] Used velocity context param to hide the buttons instead. Removed JavaScript and added tests for the non-profile-pic template.
David Chui, Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal, Ben Speakmon.
Review
CR-313
ADVMACROS-67 htmlEscape the thumbnail title, and change all...
25839: ADVMACROS-67 htmlEscape the thumbnail title, and change all webwork.htmlEncode() to generalUtil.htmlEncode() for consistency."
Under Review
1 file
0 comments
CR-313
ADVMACROS-67 htmlEscape the thumbnail title, and change all...
»
25839: ADVMACROS-67 htmlEscape the thumbnail title, and change all webwork.htmlEncode() to generalUtil.htmlEncode() for consistency."
Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal, Ben Speakmon.
Review
CR-312
- CONF-13667: allow criteria prefixes on labels in default...
25836: - CONF-13667: allow criteria prefixes on labels in default parameter - ADVMACROS-69: change operator=AND to act as if all labels are prefixed with '+'
Under Review
1 file
1 comment
CR-312
- CONF-13667: allow criteria prefixes on labels in default...
»
25836:
- CONF-13667: allow criteria prefixes on labels in default parameter
- ADVMACROS-69: change operator=AND to act as if all labels are prefixed with '+'
Ben Speakmon, Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal.
Review
CR-311
Added anti test for ADVMACROS-28 and CONF-13117 into BlogPost...
25817: Added anti test for ADVMACROS-28 and CONF-13117 into BlogPost test case We could never reproduce this, but adding a test case is still a good idea.
Under Review
2 files
2 comments
CR-311
Added anti test for ADVMACROS-28 and CONF-13117 into BlogPost...
»
25817: Added anti test for ADVMACROS-28 and CONF-13117 into BlogPost test case
We could never reproduce this, but adding a test case is still a good idea.
Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal, Ben Speakmon.
Review
CR-310
- CONF-13705: allow macros to throw ParameterException that...
CONF-13705: allow macros to throw ParameterException that contains the invalid label/space message
Under Review
4 files
0 comments
CR-310
- CONF-13705: allow macros to throw ParameterException that...
»
CONF-13705: allow macros to throw ParameterException that contains the invalid label/space message
Jonathan Nolen, Ben Speakmon, Nathan Dwyer, Cheryl Jerozal.
Review
CR-309
CONF-12749
25830: CONF-12749 Added checks for a single-space search, and code to include the space key in the label link when multiple spaces are being searched. Added an integration test.
Under Review
3 files
1 comment
25830:
CONF-12749
Added checks for a single-space search, and code to include the space key in the label link
when multiple spaces are being searched.
Added an integration test.
Nathan Dwyer, Jonathan Nolen, Ben Speakmon.
Review
CR-308
ILR-5 making plugin compatible with JIRA 3.13
Anton, I was unable to show you at Atlascamp the problems I am facing with unit testing of my plugin. My plugin worked for c.a. 1.5 year without any issues. Now it's broken in 3.13. Several people complained on that recently asking me for help. I am highlighting the issues I have using Crucible comments below. I would appreciate if you could take a look on that or assign somebody from your team to help me. This code review should readable only with sources in full context (not merely diff) or from IntelliJ Connector
Under Review
3 files
4 comments
CR-308
ILR-5 making plugin compatible with JIRA 3.13
»
Anton,
I was unable to show you at Atlascamp the problems I am facing with unit testing of my plugin.
My plugin worked for c.a. 1.5 year without any issues. Now it's broken in 3.13.
Several people complained on that recently asking me for help.
I am highlighting the issues I have using Crucible comments below.
I would appreciate if you could take a look on that or assign somebody from your team to help me.
This code review should readable only with sources in full context (not merely diff) or from IntelliJ Connector
Wojtek Seliga, Anton Mazkovoi.
Review
CR-307
ADVMACROS-75 Reverse parameter is ignored if the is no sort...
25801: ADVMACROS-75 Reverse parameter is ignored if the is no sort parameter.
Under Review
2 files
2 comments
CR-307
ADVMACROS-75 Reverse parameter is ignored if the is no sort...
»
25801: ADVMACROS-75 Reverse parameter is ignored if the is no sort parameter.
Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal, Ben Speakmon.
Review
CR-305
Tests for Content Filtering Macros
Tests for Content Filtering Macros.
Under Review
12 files
3 comments
CR-305
Tests for Content Filtering Macros
»
Tests for Content Filtering Macros.
Jonathan Nolen, David Chui, Nathan Dwyer, Cheryl Jerozal, Ben Speakmon.
Review
CR-304
CONF-13504 - added back in the profile-pic template.
25786: CONF-13504 - added back in the profile-pic template.
Under Review
2 files
1 comment
CR-304
CONF-13504 - added back in the profile-pic template.
»
25786: CONF-13504 - added back in the profile-pic template.
Jonathan Nolen, Nathan Dwyer, Cheryl Jerozal, Ben Speakmon.
Review
CR-303
- CONF-13502: fix space/author names not appearing next to...
24742: - CONF-13502: fix space/author names not appearing next to results
Under Review
1 file
2 comments
CR-303
- CONF-13502: fix space/author names not appearing next to...
»
24742: - CONF-13502: fix space/author names not appearing next to results
Jonathan Nolen, Ben Speakmon, Nathan Dwyer, Cheryl Jerozal.
Review
CR-300
- CONF-13751: default to ContentFilteringMacro's DEFAULT_MAX_RESULTS...
25722: - CONF-13751: default to ContentFilteringMacro's DEFAULT_MAX_RESULTS for value of max
Under Review
3 files
1 comment
CR-300
- CONF-13751: default to ContentFilteringMacro's DEFAULT_MAX_RESULTS...
»
25722: - CONF-13751: default to ContentFilteringMacro's DEFAULT_MAX_RESULTS for value of max
Jonathan Nolen, Ben Speakmon, Nathan Dwyer, Cheryl Jerozal.
Review
CR-291
Clean up Jira Issues Plugin
This is a preliminary attempt to get this plugin in a more manageable state. Large sections have not been touched, and this hasn't been extensively tested, but I still feel this needs to be done fairly soon for this plugin to be maintainable.
Under Review
13 files
1 comment
CR-291
Clean up Jira Issues Plugin
»
This is a preliminary attempt to get this plugin in a more manageable state. Large sections have not been touched, and this hasn't been extensively tested, but I still feel this needs to be done fairly soon for this plugin to be maintainable.
Andrew Lynch, Cheryl Jerozal, Nathan Dwyer, Jonathan Nolen, Tim Moore.
Review
CR-288
- ADVMACROS-18/ADVMACROS-19/ADVMACROS-20: implement search...
23306: - ADVMACROS-18/ADVMACROS-19/ADVMACROS-20: implement search result sort/reverse for blog-posts - removed unused pageId parameter from assertTextsPresentInOrder
Under Review
3 files
5 comments
CR-288
- ADVMACROS-18/ADVMACROS-19/ADVMACROS-20: implement search...
»
23306:
- ADVMACROS-18/ADVMACROS-19/ADVMACROS-20: implement search result sort/reverse for blog-posts
- removed unused pageId parameter from assertTextsPresentInOrder
Ben Speakmon, Brian Nguyen.
Review
CR-287
CONFJIRA-10 CONFJIRA-66 CONFJIRA-97 CONFJIRA-101
23681: CONFJIRA-10 CONFJIRA-66 CONFJIRA-97 CONFJIRA-101 Organized the XML parsing code in both the servlet and the macro to consistently handle icon mapping. Some common code was extracted to JiraIssuesUtils (which will soon re refactored). Fixed up some inconsistencies in how icon map keys were being handled so that XML and Unicode characters are handled correctly
Under Review
5 files
6 comments
CR-287
CONFJIRA-10 CONFJIRA-66 CONFJIRA-97 CONFJIRA-101
»
23681:
CONFJIRA-10 CONFJIRA-66 CONFJIRA-97 CONFJIRA-101
Organized the XML parsing code in both the servlet and the macro to consistently
handle icon mapping. Some common code was extracted to JiraIssuesUtils (which will
soon re refactored).
Fixed up some inconsistencies in how icon map keys were being handled so that XML and Unicode
characters are handled correctly
Andrew Lynch, Nathan Dwyer.
Review
CR-282
GZIPFILTER-17: Do not use the JDK's String#split method
23982: GZIPFILTER-17: Didn't quite apply the provided patch. Uses the commons-lang StringUtils.split method and "shades" the commons-lang library.
Under Review
2 files
2 comments
CR-282
GZIPFILTER-17: Do not use the JDK's String#split method
»
23982: GZIPFILTER-17: Didn't quite apply the provided patch. Uses the commons-lang StringUtils.split method and "shades" the commons-lang library.
Samuel LeBerrigaud, David Cheney, Scott Farquhar.
Review
CR-281
CRUC-696: upgrade to api changes
23898: CRUC-696: upgrade to api changes
Under Review
3 files
7 comments
CR-281
CRUC-696: upgrade to api changes
»
23898: CRUC-696: upgrade to api changes
Matt Quail, Ross Rowe, Tom Davies.
Review
CR-276
Fix for CONFJIRA-76 and CONFJIRA-84.
23026: Fix for CONFJIRA-76 and CONFJIRA-84.
Under Review
6 files
3 comments
CR-276
Fix for CONFJIRA-76 and CONFJIRA-84.
»
23026: Fix for CONFJIRA-76 and CONFJIRA-84.
Jonathan Nolen, David Chui, Tim Moore, Cheryl Jerozal.
Review
CR-265
CONFJIRA-10: using iconUrls in xml from jira if it is there...
22596: CONFJIRA-10: using iconUrls in xml from jira if it is there and if there isn't already a manual mapping. also refactoring so that jiraissuesutils gets jiraiconmappingmanager injected instead of it being injected to both the macro and servlet just for passing it in to the utils
Under Review
5 files
0 comments
CR-265
CONFJIRA-10: using iconUrls in xml from jira if it is there...
»
22596:
CONFJIRA-10: using iconUrls in xml from jira if it is there and if there isn't already a manual mapping.
also refactoring so that jiraissuesutils gets jiraiconmappingmanager injected instead of it being injected to both the macro and servlet just for passing it in to the utils
Summarize
CR-254
CONF-12549 adding test for this error
21320: CONF-12549 adding test for this error
Summarize
3 files
2 comments
CR-254
CONF-12549 adding test for this error
»
21320: CONF-12549 adding test for this error
Cheryl Jerozal, Brian Nguyen.
Review
CR-252
PROF-76 Final changes
22378: PROF-76 Final changes
Under Review
2 files
2 comments
CR-252
PROF-76 Final changes
»
22378: PROF-76 Final changes
Brian Nguyen, Samuel LeBerrigaud.
Summarize
CR-245
PROF-76 Added a strategy interface so that activation by...
21730: PROF-76 Added a strategy interface so that activation by servlet request can be overridden
Summarize
12 files
16 comments
CR-245
PROF-76 Added a strategy interface so that activation by...
»
21730: PROF-76 Added a strategy interface so that activation by servlet request can be overridden
Brian Nguyen, Samuel LeBerrigaud, Matthew Jensen, Andrew Lynch.
Review
CR-241
MARK-86 Update captcha enabling code to mirror how its been...
21296: MARK-86 Update captcha enabling code to mirror how its been done inside Confluence for maintainability
Under Review
3 files
0 comments
CR-241
MARK-86 Update captcha enabling code to mirror how its been...
»
21296: MARK-86 Update captcha enabling code to mirror how its been done inside Confluence for maintainability
Jonathan Nolen, Ryan Talusan, Dave Loeng.
Review
CR-240
CONFJIRA-44 Printed a short message with log.warn, and the...
21218: CONFJIRA-44 Printed a short message with log.warn, and the stack trace with log.debug
Under Review
1 file
1 comment
CR-240
CONFJIRA-44 Printed a short message with log.warn, and the...
»
21218: CONFJIRA-44 Printed a short message with log.warn, and the stack trace with log.debug
David Taylor, Ryan Talusan.
Review
CR-234
CLMVN-64: Allow custom report descriptor to be specified on the classpath, like clover.license
see http://forums.atlassian.com/thread.jspa?threadID=26736&tstart=0
Under Review
2 files
0 comments
CR-234
CLMVN-64: Allow custom report descriptor to be specified on the classpath, like clover.license
»
Nick Pellow, Pawel Niewiadomski.
Review
CR-232
Updated to make the macro work when exporting to PDF and Word....
20710: Updated to make the macro work when exporting to PDF and Word. Generate a regular HTML table, instead of AJAX, when rendered in PDF and Word
Under Review
6 files
1 comment
CR-232
Updated to make the macro work when exporting to PDF and Word....
»
20710: Updated to make the macro work when exporting to PDF and Word. Generate a regular HTML table, instead of AJAX, when rendered in PDF and Word
Jonathan Nolen, Ryan Talusan, Tim Moore.
Review
CR-229
The sync command now ignores the output of your command....
20548: The sync command now ignores the output of your command. Logging also doesn't double the amount of Max memory required for a command (BAM-2830)
Under Review
2 files
1 comment
CR-229
The sync command now ignores the output of your command....
»
20548: The sync command now ignores the output of your command. Logging also doesn't double the amount of Max memory required for a command (BAM-2830)
Mark Chaimungkalanont, Brydie McCoy.
Review
CR-227
Charts Macro UI Update
Improve Charts Macro UI
Under Review
19 files
4 comments
CR-227
Charts Macro UI Update
»
Improve Charts Macro UI
Ryan Talusan, Jonathan Nolen, Tim Moore, Richard Wallace, Cheryl Jerozal, Ben Speakmon.
Review
CR-224
HSP-1 a modify svn log message
13629: HSP-1 a modify svn log message
Under Review
1 file
0 comments
CR-224
HSP-1 a modify svn log message
»
13629: HSP-1 a modify svn log message
Andreas Knecht, David Chui.
Review
CR-222
FISH-89: Updated {{readme.txt}} with:
We need to run this by all the *major* stakeholders: * Marketing * {{JIRA}} team * {{FishEye}} team 20208: FISH-89: Updated {{readme.txt}} with: * Dependency on _atlassian-p4package_ jar * Brief install instructions * Link to [FishEye Plugin homepage|http://confluence.atlassian.com/display/JIRAEXT/FishEye+for+JIRA] + improved the description a bit :)
Under Review
1 file
0 comments
CR-222
FISH-89: Updated {{readme.txt}} with:
»
We need to run this by all the *major* stakeholders:
* Marketing
* {{JIRA}} team
* {{FishEye}} team
20208:
FISH-89: Updated {{readme.txt}} with:
* Dependency on _atlassian-p4package_ jar
* Brief install instructions
* Link to [FishEye Plugin homepage|
http://confluence.atlassian.com/display/JIRAEXT/FishEye+for+JIRA]
+ improved the description a bit :)
Review
CR-220
SER-123: Upgrade to OSCore 2.2.7
Upgrade to oscore 2.2.7 and upgrade base pom
Under Review
1 file
0 comments
CR-220
SER-123: Upgrade to OSCore 2.2.7
»
Upgrade to oscore 2.2.7 and upgrade base pom
James Dumay, Samuel LeBerrigaud.
Review
CR-219
Perforce Workflow Create Job Post-Function Upgrade Task
Under Review
2 files
0 comments
CR-219
Perforce Workflow Create Job Post-Function Upgrade Task
»
Review
CR-216
PageTree macro updates
Make PageTree and Page Tree Search work in 2.9 Add 'start depth' param Add expand-all and collapse-all Fold in the pagetree-search plugin, which is similar and often used in conjunction. Add @none and @home values for the root parameter.
Under Review
21 files
4 comments
CR-216
PageTree macro updates
»
Make PageTree and Page Tree Search work in 2.9
Add 'start depth' param
Add expand-all and collapse-all
Fold in the pagetree-search plugin, which is similar and often used in conjunction.
Add @none and @home values for the root parameter.
Ryan Talusan, Jonathan Nolen, Tim Moore, Richard Wallace, Cheryl Jerozal, Ben Speakmon.
Review
CR-207
Some further changes as suggested by the crucible review CR-204...
Some further changes as suggested by the crucible review CR-204 - Moved timeouts into the SeleniumConfiguration class - Re-named the SeleniumProxyUtil class to SeleniumStarter - Removed unnecessary SeleniumLogger class - Added base SeleniumTest and SeleniumTestSuite classes - Added SeleniumTestSuite class - Renamed the AtlassianHttpCommandProcessor to be use the more descriptive name HtmlDumpingHttpCommandProcessor - Added Javadoc to the SeleniumAssertions class - Made timeouts configurable - Removed unnecessary interfaces - Fixed some naming
Under Review
20 files
13 comments
CR-207
Some further changes as suggested by the crucible review CR-204...
»
Some further changes as suggested by the crucible review
CR-204- Moved timeouts into the SeleniumConfiguration class
- Re-named the SeleniumProxyUtil class to SeleniumStarter
- Removed unnecessary SeleniumLogger class
- Added base SeleniumTest and SeleniumTestSuite classes
- Added SeleniumTestSuite class
- Renamed the AtlassianHttpCommandProcessor to be use the more descriptive name HtmlDumpingHttpCommandProcessor
- Added Javadoc to the SeleniumAssertions class
- Made timeouts configurable
- Removed unnecessary interfaces
- Fixed some naming
Hamish Barney, Brad Baker, Sherali Karimov, Matt Ryall, Agnes Ro, Andrew Prentice, Samuel LeBerrigaud.
Review
CR-205
Changed functionality so that it finds modules in the reactor...
19147: Changed functionality so that it finds modules in the reactor instead of looking at the dependencies of the immediate project
Under Review
2 files
4 comments
CR-205
Changed functionality so that it finds modules in the reactor...
»
19147: Changed functionality so that it finds modules in the reactor instead of looking at the dependencies of the immediate project
James Dumay, Samuel LeBerrigaud.
Review
CR-202
SER-65: Concurrency problem found while load testing JIRA - Fix PathMapper and CachedPathMapper thread safety - use backport-util-concurrent library
Originally from [JSP-4848|https://support.atlassian.com/browse/JSP-4848] it seems like seraph: 2006-03-02 11:30:43,279 ERROR [500ErrorPage] Exception caught in 500 page No constraints matched for path /includes/js/calendar/skins/aqua/theme.css java.lang.RuntimeException: No constraints matched for path /includes/js/calendar/skins/aqua/theme.css at com.atlassian.seraph.service.PathService.getRequiredRoles(PathService.java:151) at com.atlassian.seraph.service.PathService.getRequiredRoles(PathService.java:141) at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.java:117) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) at com.atlassian.seraph.filter.LoginFilter.doFilter(LoginFilter.java:177) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) at com.atlassian.jira.web.filters.ActionCleanupDelayFilter.doFilter(ActionCleanupDelayFilter.java:37) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) at com.atlassian.core.filters.AbstractEncodingFilter.doFilter(AbstractEncodingFilter.java:37) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:856) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:744) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595)
Under Review
9 files
7 comments
CR-202
SER-65: Concurrency problem found while load testing JIRA - Fix PathMapper and CachedPathMapper thread safety - use backport-util-concurrent library
»
Originally from [JSP-4848|
https://support.atlassian.com/browse/JSP-4848] it seems like seraph:
2006-03-02 11:30:43,279 ERROR [500ErrorPage] Exception caught in 500 page No constraints matched for path /includes/js/calendar/skins/aqua/theme.css
java.lang.RuntimeException: No constraints matched for path /includes/js/calendar/skins/aqua/theme.css
at com.atlassian.seraph.service.PathService.getRequiredRoles(PathService.java:151)
at com.atlassian.seraph.service.PathService.getRequiredRoles(PathService.java:141)
at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.java:117)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at com.atlassian.seraph.filter.LoginFilter.doFilter(LoginFilter.java:177)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at com.atlassian.jira.web.filters.ActionCleanupDelayFilter.doFilter(ActionCleanupDelayFilter.java:37)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at com.atlassian.core.filters.AbstractEncodingFilter.doFilter(AbstractEncodingFilter.java:37)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:856)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:744)
at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
Jed Wesley-Smith, Samuel LeBerrigaud, Sherali Karimov, Christopher Owen, David OFlynn, Justin Koke, Mark Chaimungkalanont.
Review
CR-201
Changes to Trunk since P4 branching
Under Review
162 files
0 comments
CR-201
Changes to Trunk since P4 branching
»
Review
CR-200
Crucible P4 Assimilation
Under Review
100 files
0 comments
CR-200
Crucible P4 Assimilation
»
Review
CR-193
CLMVNONE-4, CLMVNONE-5: workaround for maven 1.0.2. Also added...
18301: CLMVNONE-4, CLMVNONE-5: workaround for maven 1.0.2. Also added new options for reporting.
Under Review
2 files
0 comments
CR-193
CLMVNONE-4, CLMVNONE-5: workaround for maven 1.0.2. Also added...
»
18301: CLMVNONE-4, CLMVNONE-5: workaround for maven 1.0.2. Also added new options for reporting.
Nick Pellow, Geoff Crain.
Review
CR-190
Maven Licenses plugin - take 2
Under Review
12 files
0 comments
CR-190
Maven Licenses plugin - take 2
»
Sherali Karimov, Samuel LeBerrigaud, James Dumay.
Summarize
CR-188
STUDIO-18, STRM-122, JST-651: Added a 'Show more...' link to...
18233: STUDIO-18, STRM-122, JST-651: Added a 'Show more...' link to the activityfeed, to give users the chance to add 10 more items to the feed incrementally without having to re-configure the max results setting. * Feel free to criticize/improve my Javascript additions. I'm crap at when it comes to writing anything in javascript :).
Summarize
3 files
3 comments
CR-188
STUDIO-18, STRM-122, JST-651: Added a 'Show more...' link to...
»
18233: STUDIO-18, STRM-122, JST-651: Added a 'Show more...' link to the activityfeed, to give users the chance to add 10 more items to the feed incrementally without having to re-configure the max results setting.
* Feel free to criticize/improve my Javascript additions. I'm crap at when it comes to writing anything in javascript :).
Andreas Knecht, Jonathan Nolen, Tim Moore.
Under Review
3 files
0 comments
fjfakl;sjf;lkjf
Review
CR-177
Studio to Trunk Merge Review
Under Review
33 files
9 comments
CR-177
Studio to Trunk Merge Review
»
Tim Pettersen, Dusan Hornik.
Review
CR-174
upgrade to use Clover 2.2. update license. remove dependencies...
17532: upgrade to use Clover 2.2. update license. remove dependencies on plugins-parent.
Under Review
11 files
5 comments
CR-174
upgrade to use Clover 2.2. update license. remove dependencies...
»
17532: upgrade to use Clover 2.2. update license. remove dependencies on plugins-parent.
Geoff Crain, Samuel LeBerrigaud, James Dumay, Nick Pellow.
Review
CR-171
CLMVN-8: Add all options to Reports e.g includeFailedTestCoverage
This is my first go at providing the full set of clover-report configuration options to the maven clover plugin. A user can now optionally specify an external clover report descriptor (the default is in resources/default-clover-report.xml). The format of this file is the same as an Ant build.xml . One of two known targets get called: 1) history - if a history point has been saved and history reports are configured 2) current - if a history report can not be generated Maven2 plugin for Clover2 should support all options defined here: http://confluence.atlassian.com/display/CLOVER/clover-report#clover-report-Current
Under Review
10 files
5 comments
CR-171
CLMVN-8: Add all options to Reports e.g includeFailedTestCoverage
»
This is my first go at providing the full set of clover-report configuration options to the maven clover plugin.
A user can now optionally specify an external clover report descriptor (the default is in resources/default-clover-report.xml). The format of this file is the same as an Ant build.xml .
One of two known targets get called:
1) history - if a history point has been saved and history reports are configured
2) current - if a history report can not be generated
Maven2 plugin for Clover2 should support all options defined here:
http://confluence.atlassian.com/display/CLOVER/clover-report#clover-report-Current